Fix Find regression where text is not selected once you...

chrome/browser/ui/views/find_bar_view.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FIND_BAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_FIND_BAR_VIEW_H_
 #pragma once
 
 #include "base/string16.h"
 #include "chrome/browser/ui/find_bar/find_notification_details.h"
@@ skipping 29 matching lines @@
     CLOSE_TAG,              // The Close button (the 'X').
   };
 
   explicit FindBarView(FindBarHost* host);
   virtual ~FindBarView();
 
   // Gets/sets the text displayed in the text box.
   string16 GetFindText() const;
   void SetFindText(const string16& find_text);
 
+  // Gets the selected text in the text box.
+  string16 GetFindSelectedText() const;
+
   // Gets the match count text displayed in the text box.
   string16 GetMatchCountText() const;
 
   // Updates the label inside the Find text box that shows the ordinal of the
   // active item and how many matches were found.
   void UpdateForResult(const FindNotificationDetails& result,
                        const string16& find_text);
 
   // Clears the current Match Count value in the Find text box.
   void ClearMatchCount();
@@ skipping 38 matching lines @@
       : view_to_focus_on_mousedown_(view_to_focus_on_mousedown) {}
 
    private:
     virtual bool OnMousePressed(const views::MouseEvent& event);
 
     views::Textfield* view_to_focus_on_mousedown_;
 
     DISALLOW_COPY_AND_ASSIGN(FocusForwarderView);
   };
 
+  // A wrapper of views::TextField that allows us to select all text when we
+  // get focus. Represents the text field where the user enters a search term.
+  class SearchTextfieldView : public views::Textfield {

[Jay Civelli, 2010/12/06 22:14:09]

May be that could have been added as a property of the Textfield?

+   public:
+     SearchTextfieldView();
+     virtual ~SearchTextfieldView();
+
+     virtual void RequestFocus();
+
+   private:
+     DISALLOW_COPY_AND_ASSIGN(SearchTextfieldView);
+  };
+
   // Returns the OS-specific view for the find bar that acts as an intermediary
   // between us and the TabContentsView.
   FindBarHost* find_bar_host() const;
 
 #if defined(OS_LINUX)
-  // In gtk we get changed signals if we programatically set the text. If we
+  // In GTK we get changed signals if we programmatically set the text. If we
   // don't ignore them we run into problems. For example, switching tabs back
   // to one with the find bar visible will cause a search to the next found
   // text. Also if the find bar had been visible and then hidden and the user
   // switches back, found text will be highlighted again.
   bool ignore_contents_changed_;
 #endif
 
   // The controls in the window.
-  views::Textfield* find_text_;
+  SearchTextfieldView* find_text_;
   views::Label* match_count_text_;
   FocusForwarderView* focus_forwarder_view_;
   views::ImageButton* find_previous_button_;
   views::ImageButton* find_next_button_;
   views::ImageButton* close_button_;
 
   DISALLOW_COPY_AND_ASSIGN(FindBarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FIND_BAR_VIEW_H_