Fix exit frame type in breakpoint stub

src/codegen.cc

Index: src/codegen.cc
===================================================================
--- src/codegen.cc	(revision 3774)
+++ src/codegen.cc	(working copy)
@@ -479,6 +479,19 @@
 }
 
 
+int CEntryStub::MinorKey() {
+  ASSERT(result_size_ <= 2);
+#ifdef _WIN64
+  const indirect_result = result_size_ > 1;

[William Hesse, 2010/02/03 06:18:35]

This seems really wrong.  Either make the type (int) explicit, or make this a
constant bool.

+#else
+  const bool indirect_result = false;
+#endif
+
+  return ExitFrameModeBits::encode(mode_)
+         | IndirectResultBits::encode(indirect_result > 1);

[William Hesse, 2010/02/03 06:18:35]

Shouldn't this just be indirect_result, not indirect_result > 1?  The second
expression is never true.

In all cases except _WIN64, this is encoding 0, which probably doesn't affect
the bitwise or, so maybe the entire return statement should be in an #ifdef, and
be optimized in all cases except WIN64 to just return
ExitFrameModeBits::encode(mode).

+}
+
+
 bool ApiGetterEntryStub::GetCustomCache(Code** code_out) {
   Object* cache = info()->load_stub_cache();
   if (cache->IsUndefined()) {