Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/codegen.h

Issue 555164: Fix exit frame type in breakpoint stub (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/debug-arm.cc ('k') | src/codegen.cc » ('j') | src/codegen.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen.h
===================================================================
--- src/codegen.h (revision 3774)
+++ src/codegen.h (working copy)
@@ -330,26 +330,31 @@
class CEntryStub : public CodeStub {
public:
- explicit CEntryStub(int result_size) : result_size_(result_size) { }
+ explicit CEntryStub(int result_size,
+ ExitFrame::Mode mode = ExitFrame::MODE_NORMAL)
+ : result_size_(result_size), mode_(mode) { }
- void Generate(MacroAssembler* masm) { GenerateBody(masm, false); }
+ void Generate(MacroAssembler* masm);
- protected:
- void GenerateBody(MacroAssembler* masm, bool is_debug_break);
+ private:
void GenerateCore(MacroAssembler* masm,
Label* throw_normal_exception,
Label* throw_termination_exception,
Label* throw_out_of_memory_exception,
- ExitFrame::Mode mode,
bool do_gc,
bool always_allocate_scope);
void GenerateThrowTOS(MacroAssembler* masm);
void GenerateThrowUncatchable(MacroAssembler* masm,
UncatchableExceptionType type);
- private:
+
// Number of pointers/values returned.
- int result_size_;
+ int const result_size_;
+ ExitFrame::Mode const mode_;
+ // Minor key encoding
+ class ExitFrameModeBits: public BitField<ExitFrame::Mode, 0, 1> {};
+ class IndirectResultBits: public BitField<bool, 1, 1> {};
+
Major MajorKey() { return CEntry; }
// Minor key must differ if different result_size_ values means different
// code is generated.
@@ -385,7 +390,7 @@
};
-// Mark the debugger statemet to be recognized bu debugger (by the MajorKey)
+// Mark the debugger statemet to be recognized by debugger (by the MajorKey)
class DebugerStatementStub : public CodeStub {
public:
DebugerStatementStub() { }
« no previous file with comments | « src/arm/debug-arm.cc ('k') | src/codegen.cc » ('j') | src/codegen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698