Refactor some code that depends on FFmpeg

Refactor some code that depends on FFmpeg

Some FFmpeg header and source files are misplaced:

media/filters/ffmpeg_common.{cc, h} -> media/ffmpeg
media/tools/media_bench/file_protocol.{cc, h} -> media/ffmpeg

And the necessary refactoring for the new location is done.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37080

[awong, 2010-01-26 00:12:01]

On 2010/01/26 00:09:37, Alpha wrote:
> 

I think the copy right is just supposed to be 2010, not 2009-2010.

Ask on IRC?

-A

[Alpha Left Google, 2010-01-26 00:44:22]

Corrected to 2010.

[awong, 2010-01-26 00:46:54]

LGTM

[fbarchard, 2010-01-26 01:05:47]

media/tools/media_bench/file_protocol.{cc, h} seems like the right place for
these, since they are specific to media_bench?

[hclam, 2010-01-26 01:07:42]

2010/1/25 <fbarchard@chromium.org>

> media/tools/media_bench/file_protocol.{cc, h} seems like the right place
> for
> these, since they are specific to media_bench?

I'm also planning to use them in omx_test, they are more like ffmpeg utils
so putting them in media/ffmpeg we can share the same code.



>
>
>
>
> http://codereview.chromium.org/555087
>

[fbarchard, 2010-01-26 01:57:35]

LGTM - ok, so long as we dont expect it to work outside of the media_bench and
omx_test.  Its just a minimal implementation for the benchmark(s)

[awong, 2010-01-26 01:59:41]

That this information to the file comment if it's not already there?

People are supposed to read those before using what's in the file, so having
a "this is mean for X, and is not a complete implementation of Y.  Only use
this if you satisfy Z." kind of comment is completely legit.

On Mon, Jan 25, 2010 at 5:57 PM, <fbarchard@chromium.org> wrote:

> LGTM - ok, so long as we dont expect it to work outside of the media_bench
> and
> omx_test.  Its just a minimal implementation for the benchmark(s)
>
>
>
> http://codereview.chromium.org/555087
>