Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5544010: Revert 68293 - Revert 68290 - Restored missing BrokerRpcClient::Connect.... (Closed)

Created:
10 years ago by Jói
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ceee-reviews_chromium.org
Visibility:
Public.

Description

Revert 68293 - Revert 68290 - Restored missing BrokerRpcClient::Connect. Fixed leaking of BrokerRpcClient. (relanding for vitalybuka@chromium.org) BUG=65392 TEST=none Review URL: http://codereview.chromium.org/5610004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/5533007 TBR=joi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M ceee/ie/plugin/bho/cookie_accountant.h View 2 chunks +7 lines, -1 line 0 comments Download
M ceee/ie/plugin/bho/executor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ceee/ie/plugin/bho/executor.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M ceee/ie/plugin/bho/webrequest_notifier.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ceee/ie/plugin/bho/webrequest_notifier.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
10 years ago (2010-12-04 20:45:36 UTC) #1
Vitaly Buka (NO REVIEWS)
10 years ago (2010-12-05 04:12:46 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698