Issue 5610004: Restored missing BrokerRpcClient::Connect.

Issue 5610004: Restored missing BrokerRpcClient::Connect. (Closed)

Created:
10 years ago by Vitaly Buka (NO REVIEWS)

Modified:
9 years, 7 months ago

Reviewers:
Jói

CC:
chromium-reviews, ceee-reviews_chromium.org, hansl

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Restored missing BrokerRpcClient::Connect. Fixed leaking of BrokerRpcClient. BUG=65392 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68290

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
M	ceee/ie/plugin/bho/cookie_accountant.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	ceee/ie/plugin/bho/executor.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ceee/ie/plugin/bho/executor.cc	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
M	ceee/ie/plugin/bho/webrequest_notifier.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ceee/ie/plugin/bho/webrequest_notifier.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM one nit I noticed on re-review http://codereview.chromium.org/5610004/diff/1/ceee/ie/plugin/bho/executor.cc File ceee/ie/plugin/bho/executor.cc (right): http://codereview.chromium.org/5610004/diff/1/ceee/ie/plugin/bho/executor.cc#newcode375 ceee/ie/plugin/bho/executor.cc:375: broker_rpc_client_(false) { ...

10 years ago (2010-12-04 14:03:58 UTC) #3

Vitaly Buka (NO REVIEWS)

http://codereview.chromium.org/5610004/diff/1/ceee/ie/plugin/bho/executor.cc File ceee/ie/plugin/bho/executor.cc (right): http://codereview.chromium.org/5610004/diff/1/ceee/ie/plugin/bho/executor.cc#newcode375 ceee/ie/plugin/bho/executor.cc:375: broker_rpc_client_(false) { On 2010/12/04 14:03:58, Jói wrote: > Please ...

10 years ago (2010-12-04 18:23:22 UTC) #4

Jói

10 years ago (2010-12-04 18:40:32 UTC) #5

LGTM

On Sat, Dec 4, 2010 at 1:23 PM,  <vitalybuka@chromium.org> wrote:
>
> http://codereview.chromium.org/5610004/diff/1/ceee/ie/plugin/bho/executor.cc
> File ceee/ie/plugin/bho/executor.cc (right):
>
>
http://codereview.chromium.org/5610004/diff/1/ceee/ie/plugin/bho/executor.cc#...
> ceee/ie/plugin/bho/executor.cc:375: broker_rpc_client_(false) {
> On 2010/12/04 14:03:58, Jói wrote:
>>
>> Please add a comment explaining why allow_restarts needs to be false
>
> in this
>>
>> case.
>
> Done.
>
> http://codereview.chromium.org/5610004/
>

Expand Messages | Collapse Messages