Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5544002: Move a bunch more browser stuff around.... (Closed)

Created:
10 years ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Move a bunch more browser stuff around. toolbar stuff -> ui/toolbar dock_info -> ui/tabs window_sizer -> ui BUG=none TEST=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -5537 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/back_forward_menu_model.h View 1 chunk +0 lines, -171 lines 0 comments Download
D chrome/browser/back_forward_menu_model.cc View 1 chunk +0 lines, -379 lines 0 comments Download
D chrome/browser/back_forward_menu_model_unittest.cc View 1 chunk +0 lines, -422 lines 0 comments Download
M chrome/browser/chromeos/notifications/balloon_collection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/options_window_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/dock_info.h View 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/browser/dock_info.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D chrome/browser/dock_info_gtk.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D chrome/browser/dock_info_mac.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/dock_info_unittest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/browser/dock_info_win.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D chrome/browser/encoding_menu_controller.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/encoding_menu_controller.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/encoding_menu_controller_unittest.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M chrome/browser/extensions/extension_popup_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/back_forward_button_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/options_window_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_collection.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/toolbar_model.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/toolbar_model.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/back_forward_menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/back_forward_menu_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/encoding_menu_controller_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/tabs/dock_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/dock_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/tabs/dock_info_gtk.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/tabs/dock_info_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/tabs/dock_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/tabs/dock_info_win.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + chrome/browser/ui/toolbar/back_forward_menu_model.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/toolbar/encoding_menu_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/toolbar/encoding_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/toolbar/encoding_menu_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/toolbar/toolbar_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/toolbar/toolbar_model.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/toolbar/wrench_menu_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/toolbar/wrench_menu_model.cc View 4 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill_profiles_view_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/info_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/options_window_view.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/window_sizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/window_sizer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/window_sizer_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/window_sizer_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/window_sizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/window_sizer_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/window_sizer.h View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/window_sizer.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D chrome/browser/window_sizer_linux.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/window_sizer_mac.mm View 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/browser/window_sizer_unittest.cc View 1 chunk +0 lines, -1002 lines 0 comments Download
D chrome/browser/window_sizer_win.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/browser/wrench_menu_model.h View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/wrench_menu_model.cc View 1 chunk +0 lines, -539 lines 0 comments Download
D chrome/browser/wrench_menu_model_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M chrome/chrome_browser.gypi View 12 chunks +23 lines, -25 lines 0 comments Download
M chrome/chrome_tests.gypi View 7 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/plugin/pdf_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
10 years ago (2010-12-02 17:02:21 UTC) #1
brettw
10 years ago (2010-12-02 17:05:45 UTC) #2 
LGTM rubber stamp.

Powered by Google App Engine
This is Rietveld 408576698