Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: src/data-flow.cc

Issue 553149: Implement simple fast-path code for functions containing this property stores and global variables. (Closed)
Patch Set: Incorporated codereview comments. Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/data-flow.h ('k') | src/fast-codegen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/data-flow.cc
diff --git a/src/data-flow.cc b/src/data-flow.cc
index ef15244a4e6aa4c964d1f4000cf3d711367b355a..0e30b315173f879a91d87a9a42d163402cbaf40b 100644
--- a/src/data-flow.cc
+++ b/src/data-flow.cc
@@ -196,9 +196,12 @@ void AstLabeler::VisitAssignment(Assignment* expr) {
ASSERT(prop != NULL);
if (prop != NULL) {
ASSERT(prop->key()->IsPropertyName());
- if (prop->obj()->AsVariableProxy() == NULL ||
- !prop->obj()->AsVariableProxy()->var()->is_this())
+ VariableProxy* proxy = prop->obj()->AsVariableProxy();
+ if (proxy != NULL && proxy->var()->is_this()) {
+ has_this_properties_ = true;
+ } else {
Visit(prop->obj());
+ }
}
Visit(expr->value());
expr->set_num(next_number_++);
« no previous file with comments | « src/data-flow.h ('k') | src/fast-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698