Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/data-flow.cc

Issue 553149: Implement simple fast-path code for functions containing this property stores and global variables. (Closed)
Patch Set: Incorporated codereview comments. Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/data-flow.h ('k') | src/fast-codegen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 CatchExtensionObject* expr) { 189 CatchExtensionObject* expr) {
190 UNREACHABLE(); 190 UNREACHABLE();
191 } 191 }
192 192
193 193
194 void AstLabeler::VisitAssignment(Assignment* expr) { 194 void AstLabeler::VisitAssignment(Assignment* expr) {
195 Property* prop = expr->target()->AsProperty(); 195 Property* prop = expr->target()->AsProperty();
196 ASSERT(prop != NULL); 196 ASSERT(prop != NULL);
197 if (prop != NULL) { 197 if (prop != NULL) {
198 ASSERT(prop->key()->IsPropertyName()); 198 ASSERT(prop->key()->IsPropertyName());
199 if (prop->obj()->AsVariableProxy() == NULL || 199 VariableProxy* proxy = prop->obj()->AsVariableProxy();
200 !prop->obj()->AsVariableProxy()->var()->is_this()) 200 if (proxy != NULL && proxy->var()->is_this()) {
201 has_this_properties_ = true;
202 } else {
201 Visit(prop->obj()); 203 Visit(prop->obj());
204 }
202 } 205 }
203 Visit(expr->value()); 206 Visit(expr->value());
204 expr->set_num(next_number_++); 207 expr->set_num(next_number_++);
205 } 208 }
206 209
207 210
208 void AstLabeler::VisitThrow(Throw* expr) { 211 void AstLabeler::VisitThrow(Throw* expr) {
209 UNREACHABLE(); 212 UNREACHABLE();
210 } 213 }
211 214
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 void AstLabeler::VisitThisFunction(ThisFunction* expr) { 258 void AstLabeler::VisitThisFunction(ThisFunction* expr) {
256 UNREACHABLE(); 259 UNREACHABLE();
257 } 260 }
258 261
259 262
260 void AstLabeler::VisitDeclaration(Declaration* decl) { 263 void AstLabeler::VisitDeclaration(Declaration* decl) {
261 UNREACHABLE(); 264 UNREACHABLE();
262 } 265 }
263 266
264 } } // namespace v8::internal 267 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/data-flow.h ('k') | src/fast-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698