Mac: Use high-quality interpolation to draw tabpose thumbnails.

Mac: Use high-quality interpolation to draw tabpose thumbnails.

BUG=50307, 65894
TEST=Activate tabpose, thumbnails should look nicer, but the feature shouldn't be visibly slower.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68610

[viettrungluu, 2010-12-08 17:38:13]

http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
File gfx/scoped_cg_context_state_mac.h (right):

http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
gfx/scoped_cg_context_state_mac.h:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
Is gfx/ really the place for this?

I mainly ask because there's a conspicuous absence of (directly) CG-supporting
stuff in that directory.

http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
gfx/scoped_cg_context_state_mac.h:15: : context_(context) {
indentation

http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
gfx/scoped_cg_context_state_mac.h:25: };
DISALLOW_STUFF()?

[Nico, 2010-12-08 18:11:20]

On Wed, Dec 8, 2010 at 9:38 AM,  <viettrungluu@chromium.org> wrote:
>
>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
> File gfx/scoped_cg_context_state_mac.h (right):
>
>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
> gfx/scoped_cg_context_state_mac.h:1: // Copyright (c) 2010 The Chromium
> Authors. All rights reserved.
> Is gfx/ really the place for this?

I'm not sure. A quick `git gs CGContextSaveGState` shows places that
should probably use this class in gfx, skia/ext, webkit/, and chrome/
– gfx is a place all these directories could depend on, and
scoped_image is in gfx. It seems like an ok place to me, but if you
have better suggestions, I'm all ears. (+rsesek, who may or may not
have an opinion on this).

> I mainly ask because there's a conspicuous absence of (directly)
> CG-supporting stuff in that directory.
>
>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
> gfx/scoped_cg_context_state_mac.h:15: : context_(context) {
> indentation

Done.

>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
> gfx/scoped_cg_context_state_mac.h:25: };
> DISALLOW_STUFF()?

Done.

>
> http://codereview.chromium.org/5526011/
>

[Robert Sesek, 2010-12-08 18:18:58]

On 2010/12/08 18:11:20, Nico wrote:
> On Wed, Dec 8, 2010 at 9:38 AM,  <mailto:viettrungluu@chromium.org> wrote:
> >
> >
>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
> > File gfx/scoped_cg_context_state_mac.h (right):
> >
> >
>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
> > gfx/scoped_cg_context_state_mac.h:1: // Copyright (c) 2010 The Chromium
> > Authors. All rights reserved.
> > Is gfx/ really the place for this?
> 
> I'm not sure. A quick `git gs CGContextSaveGState` shows places that
> should probably use this class in gfx, skia/ext, webkit/, and chrome/
> –&nbsp;gfx is a place all these directories could depend on, and
> scoped_image is in gfx. It seems like an ok place to me, but if you
> have better suggestions, I'm all ears. (+rsesek, who may or may not
> have an opinion on this).

I'd either put this in gfx/ or base/mac/, but I think gfx/ is the best place.
Could you file a Pri3 Type-Cleanup bug to change where we manually save context
and use this instead?

[vtl, 2010-12-08 18:19:36]

LGTM, but you may want to consult other people about where to put stuff.

On Wed, Dec 8, 2010 at 10:11, Nico Weber <thakis@chromium.org> wrote:
> On Wed, Dec 8, 2010 at 9:38 AM,  <viettrungluu@chromium.org> wrote:
>>
>>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
>> File gfx/scoped_cg_context_state_mac.h (right):
>>
>>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
>> gfx/scoped_cg_context_state_mac.h:1: // Copyright (c) 2010 The Chromium
>> Authors. All rights reserved.
>> Is gfx/ really the place for this?
>
> I'm not sure. A quick `git gs CGContextSaveGState` shows places that
> should probably use this class in gfx, skia/ext, webkit/, and chrome/
> – gfx is a place all these directories could depend on, and
> scoped_image is in gfx. It seems like an ok place to me, but if you
> have better suggestions, I'm all ears. (+rsesek, who may or may not
> have an opinion on this).
>
>> I mainly ask because there's a conspicuous absence of (directly)
>> CG-supporting stuff in that directory.
>>
>>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
>> gfx/scoped_cg_context_state_mac.h:15: : context_(context) {
>> indentation
>
> Done.
>
>>
http://codereview.chromium.org/5526011/diff/2001/gfx/scoped_cg_context_state_...
>> gfx/scoped_cg_context_state_mac.h:25: };
>> DISALLOW_STUFF()?
>
> Done.
>
>>
>> http://codereview.chromium.org/5526011/
>>
>