Issue 5525001: Check offset argument to gpu::gles2::BufferManager::BufferInfo::SetRange is n...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5525001: Check offset argument to gpu::gles2::BufferManager::BufferInfo::SetRange is n... (Closed)

Created:
10 years ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
greggman

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Check offset argument to gpu::gles2::BufferManager::BufferInfo::SetRange is not negative. Prevents writing to buffer out of range. TEST=try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67937

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -9 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	4 chunks	+8 lines, -7 lines	1 comment	Download
M	gpu/command_buffer/service/buffer_manager.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager_unittest.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

greggman

10 years ago (2010-12-02 00:04:48 UTC) #2

lgtm

http://codereview.chromium.org/5525001/diff/1/gpu/command_buffer/build_gles2_...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

http://codereview.chromium.org/5525001/diff/1/gpu/command_buffer/build_gles2_...
gpu/command_buffer/build_gles2_cmd_buffer.py:4809: return
SizeNotNegativeArgument(arg_parts[-1], " ".join(arg_parts[0:-1]),
arg_parts[0][0:-11])
> 80 chars

Expand Messages | Collapse Messages