Check offset argument to gpu::gles2::BufferManager::BufferInfo::SetRange is n...

gpu/command_buffer/service/buffer_manager_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/buffer_manager.h"
 #include "gpu/command_buffer/common/gl_mock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace gpu {
 namespace gles2 {
@@ skipping 81 matching lines @@
   const uint8 data[] = {10, 9, 8, 7, 6, 5, 4, 3, 2, 1};
   manager_.CreateBufferInfo(kClientBufferId, kServiceBufferId);
   BufferManager::BufferInfo* info = manager_.GetBufferInfo(kClientBufferId);
   ASSERT_TRUE(info != NULL);
   manager_.SetTarget(info, GL_ELEMENT_ARRAY_BUFFER);
   manager_.SetSize(info, sizeof(data));
   EXPECT_TRUE(info->SetRange(0, sizeof(data), data));
   EXPECT_TRUE(info->SetRange(sizeof(data), 0, data));
   EXPECT_FALSE(info->SetRange(sizeof(data), 1, data));
   EXPECT_FALSE(info->SetRange(0, sizeof(data) + 1, data));
+  EXPECT_FALSE(info->SetRange(-1, sizeof(data), data));
+  EXPECT_FALSE(info->SetRange(0, -1, data));
 }
 
 TEST_F(BufferManagerTest, GetRange) {
   const GLuint kClientBufferId = 1;
   const GLuint kServiceBufferId = 11;
   const uint8 data[] = {10, 9, 8, 7, 6, 5, 4, 3, 2, 1};
   manager_.CreateBufferInfo(kClientBufferId, kServiceBufferId);
   BufferManager::BufferInfo* info = manager_.GetBufferInfo(kClientBufferId);
   ASSERT_TRUE(info != NULL);
   manager_.SetTarget(info, GL_ELEMENT_ARRAY_BUFFER);
   manager_.SetSize(info, sizeof(data));
   const char* buf = static_cast<const char*>(info->GetRange(0, sizeof(data)));
   ASSERT_TRUE(buf != NULL);
   const char* buf1 =
       static_cast<const char*>(info->GetRange(1, sizeof(data) - 1));
   EXPECT_EQ(buf + 1, buf1);
   EXPECT_TRUE(info->GetRange(sizeof(data), 1) == NULL);
   EXPECT_TRUE(info->GetRange(0, sizeof(data) + 1) == NULL);
+  EXPECT_TRUE(info->GetRange(-1, sizeof(data)) == NULL);
+  EXPECT_TRUE(info->GetRange(-0, -1) == NULL);
 }
 
 TEST_F(BufferManagerTest, GetMaxValueForRangeUint8) {
   const GLuint kClientBufferId = 1;
   const GLuint kServiceBufferId = 11;
   const uint8 data[] = {10, 9, 8, 7, 6, 5, 4, 3, 2, 1};
   const uint8 new_data[] = {100, 120, 110};
   manager_.CreateBufferInfo(kClientBufferId, kServiceBufferId);
   BufferManager::BufferInfo* info = manager_.GetBufferInfo(kClientBufferId);
   ASSERT_TRUE(info != NULL);
@@ skipping 82 matching lines @@
   EXPECT_EQ(120u, max_value);
   // Check out of range fails.
   EXPECT_FALSE(info->GetMaxValueForRange(0, 11, GL_UNSIGNED_INT, &max_value));
   EXPECT_FALSE(info->GetMaxValueForRange(40, 1, GL_UNSIGNED_INT, &max_value));
 }
 
 }  // namespace gles2
 }  // namespace gpu