Issue 552266: Remove trailing comma to allow compilation with Native Client's higher warnin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552266: Remove trailing comma to allow compilation with Native Client's higher warnin... (Closed)

Created:
10 years, 10 months ago by sehr (please use chromium)

Modified:
9 years, 7 months ago

Reviewers:
David Springer, apatrick, Evan Martin, apatrick_chromium

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove trailing comma to allow compilation with Native Client's higher warning level. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37749

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gpu/command_buffer/common/constants.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

What is this higher warning level? Maybe we should turn it on for all Chrome ...

10 years, 10 months ago (2010-02-01 22:33:19 UTC) #4

sehr (please use chromium)

10 years, 10 months ago (2010-02-01 22:48:16 UTC) #5

Evan,

Thanks for picking this up.  We (NaCl) build with
   '-pedantic',
    '-Wextra',
    '-Wno-long-long',
    '-Wswitch-enum',
    '-Wsign-compare',
on Linux and Mac and  /WX (with /W3, I think) on Windows

David

On Mon, Feb 1, 2010 at 2:33 PM, <evan@chromium.org> wrote:

> What is this higher warning level?  Maybe we should turn it on for all
> Chrome
> code, to help catch this kind of thing in the future?
>
>
> http://codereview.chromium.org/552266
>

Expand Messages | Collapse Messages