Add a trailing \ when printing filenames for presubmit checks....

Add a trailing \ when printing filenames for presubmit checks.

This makes it easier to apply commands to a set of files. For example:

Run the command: svn pset svn:eol-style LF \
  chrome/browser/extensions/extension_accessibility_apitest.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.cc \
  chrome/browser/extensions/extension_accessibility_api.h \
  chrome/browser/extensions/extension_accessibility_api.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.cc \
  chrome/browser/gtk/accessibility_event_router_gtk.h \
  chrome/browser/gtk/accessibility_event_router_gtk.cc \
  chrome/common/accessibility_events.cc \
  chrome/common/accessibility_events.h

requires just 1 copy-paste.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37350

[M-A Ruel, 2010-01-27 22:52:42]

Good idea, can you change presubmit_canned_checks.py at the same time so it ends
with "svn pset svn:eol-style LF \" ?

[Evan Stade, 2010-01-27 23:21:08]

ok updated. Also updated the example. Does that look ok?

[M-A Ruel, 2010-01-27 23:30:19]

lgtm as-is if you don't like my idea.

http://codereview.chromium.org/552202/diff/2002/2003
File presubmit_support.py (right):

http://codereview.chromium.org/552202/diff/2002/2003#newcode101
presubmit_support.py:101: for index, item in enumerate(self._items):
nit: what do you think about:

output_stream.write('  ' + ' \\\n  '.join(self._items) + '\n')

but it's maybe a bit unreadable.
Otherwise, you can skip trailing_chars and do
if index < (len(self._items) - 1):
  item = str(item) + ' \\'
output_stream.write('  %s\n' % str(item))

[Evan Stade, 2010-01-27 23:45:00]

updated, take a quick look?

-- Evan Stade



On Wed, Jan 27, 2010 at 3:30 PM,  <maruel@chromium.org> wrote:
> lgtm as-is if you don't like my idea.
>
>
> http://codereview.chromium.org/552202/diff/2002/2003
> File presubmit_support.py (right):
>
> http://codereview.chromium.org/552202/diff/2002/2003#newcode101
> presubmit_support.py:101: for index, item in enumerate(self._items):
> nit: what do you think about:
>
> output_stream.write('  ' + ' \\\n  '.join(self._items) + '\n')
>
> but it's maybe a bit unreadable.
> Otherwise, you can skip trailing_chars and do
> if index < (len(self._items) - 1):
>  item = str(item) + ' \\'
> output_stream.write('  %s\n' % str(item))
>
> http://codereview.chromium.org/552202
>

[M-A Ruel, 2010-01-27 23:58:15]

lgtm, just make sure running "./presubmit_support.py *.py" still succeed.