Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 552195: Make sure to initialize all fields in the special maps... (Closed)

Created:
10 years, 11 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
iposva, Rico
CC:
v8-dev
Visibility:
Public.

Description

Make sure to initialize all fields in the special maps created during bootstrapping. Without this change we risk having weird flags set on the map for the null value (among others), which can lead to crashes. Committed: http://code.google.com/p/v8/source/detail?r=3725

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap.cc View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Kasper Lund
10 years, 11 months ago (2010-01-27 19:50:46 UTC) #1
iposva
LGTM, although it might be safer to initialize the whole memory area of the map ...
10 years, 11 months ago (2010-01-27 19:55:10 UTC) #2
Rico
10 years, 11 months ago (2010-01-28 08:14:47 UTC) #3
http://codereview.chromium.org/552195/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/552195/diff/1/2#newcode1191
src/heap.cc:1191: reinterpret_cast<Map*>(result)->set_bit_field2(0);
After adding the extensible property to bit_field2 maybe this needs to be (same
as in AllocateMap):
map->set_bit_field2(1 << Map::kIsExtensible);
(default value for extensible is true)

Powered by Google App Engine
This is Rietveld 408576698