Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: src/heap.cc

Issue 552195: Make sure to initialize all fields in the special maps... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 Object* Heap::AllocatePartialMap(InstanceType instance_type, 1178 Object* Heap::AllocatePartialMap(InstanceType instance_type,
1179 int instance_size) { 1179 int instance_size) {
1180 Object* result = AllocateRawMap(); 1180 Object* result = AllocateRawMap();
1181 if (result->IsFailure()) return result; 1181 if (result->IsFailure()) return result;
1182 1182
1183 // Map::cast cannot be used due to uninitialized map field. 1183 // Map::cast cannot be used due to uninitialized map field.
1184 reinterpret_cast<Map*>(result)->set_map(raw_unchecked_meta_map()); 1184 reinterpret_cast<Map*>(result)->set_map(raw_unchecked_meta_map());
1185 reinterpret_cast<Map*>(result)->set_instance_type(instance_type); 1185 reinterpret_cast<Map*>(result)->set_instance_type(instance_type);
1186 reinterpret_cast<Map*>(result)->set_instance_size(instance_size); 1186 reinterpret_cast<Map*>(result)->set_instance_size(instance_size);
1187 reinterpret_cast<Map*>(result)->set_inobject_properties(0); 1187 reinterpret_cast<Map*>(result)->set_inobject_properties(0);
1188 reinterpret_cast<Map*>(result)->set_pre_allocated_property_fields(0);
1188 reinterpret_cast<Map*>(result)->set_unused_property_fields(0); 1189 reinterpret_cast<Map*>(result)->set_unused_property_fields(0);
1190 reinterpret_cast<Map*>(result)->set_bit_field(0);
1191 reinterpret_cast<Map*>(result)->set_bit_field2(0);
Rico 2010/01/28 08:14:48 After adding the extensible property to bit_field2
1189 return result; 1192 return result;
1190 } 1193 }
1191 1194
1192 1195
1193 Object* Heap::AllocateMap(InstanceType instance_type, int instance_size) { 1196 Object* Heap::AllocateMap(InstanceType instance_type, int instance_size) {
1194 Object* result = AllocateRawMap(); 1197 Object* result = AllocateRawMap();
1195 if (result->IsFailure()) return result; 1198 if (result->IsFailure()) return result;
1196 1199
1197 Map* map = reinterpret_cast<Map*>(result); 1200 Map* map = reinterpret_cast<Map*>(result);
1198 map->set_map(meta_map()); 1201 map->set_map(meta_map());
(...skipping 3013 matching lines...) Expand 10 before | Expand all | Expand 10 after
4212 void ExternalStringTable::TearDown() { 4215 void ExternalStringTable::TearDown() {
4213 new_space_strings_.Free(); 4216 new_space_strings_.Free();
4214 old_space_strings_.Free(); 4217 old_space_strings_.Free();
4215 } 4218 }
4216 4219
4217 4220
4218 List<Object*> ExternalStringTable::new_space_strings_; 4221 List<Object*> ExternalStringTable::new_space_strings_;
4219 List<Object*> ExternalStringTable::old_space_strings_; 4222 List<Object*> ExternalStringTable::old_space_strings_;
4220 4223
4221 } } // namespace v8::internal 4224 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698