Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 552086: Disable a test on Linux Views. It was marked as flaky, but it is failing all ... (Closed)

Created:
10 years, 11 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr., oshima
Visibility:
Public.

Description

Disable a test on Linux Views. It was marked as flaky, but it is failing all the time. See http://crbug.com/28629 for details. TBR=pkasting BUG=http://crbug.com/28629, http://crbug.com/16447 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36795

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/views/find_bar_host_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
10 years, 11 months ago (2010-01-21 21:32:54 UTC) #1
oshima
10 years, 11 months ago (2010-01-21 21:40:35 UTC) #2
LGTM

 IIRC, this used to pass more often. Thank you for reminding this.

- oshima

On Thu, Jan 21, 2010 at 1:32 PM, <finnur@chromium.org> wrote:

> Reviewers: Peter Kasting,
>
> Description:
> Disable a test on Linux Views. It was marked as flaky, but it is failing
> all the
> time.
>
> See http://crbug.com/28629 for details.
>
> TBR=pkasting
> BUG=http://crbug.com/28629, http://crbug.com/16447
> TEST=None
>
>
> Please review this at http://codereview.chromium.org/552086
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/views/find_bar_host_browsertest.cc
>
>
> Index: chrome/browser/views/find_bar_host_browsertest.cc
> ===================================================================
> --- chrome/browser/views/find_bar_host_browsertest.cc   (revision 36781)
> +++ chrome/browser/views/find_bar_host_browsertest.cc   (working copy)
> @@ -474,9 +474,9 @@
>
>  // Make sure Find box disappears on Navigate but not on Refresh.
>  #if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
> -// The last EXPECT_FALSE(fully_visible) is flaky (especially on
> -// 64bit build.). See bug http://crbug.com/28629.
> -#define FindDisappearOnNavigate FLAKY_FindDisappearOnNavigate
> +// The last EXPECT_FALSE(fully_visible) is failing all the time on
> +// the linux_views bot. See bug: http://crbug.com/28629.
> +#define FindDisappearOnNavigate DISABLED_FindDisappearOnNavigate
>  #endif
>  IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindDisappearOnNavigate)
> {
>   HTTPTestServer* server = StartHTTPServer();
>
>
>

Powered by Google App Engine
This is Rietveld 408576698