Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: chrome/browser/plugin_exceptions_table_model_unittest.cc

Issue 5516004: Clean up PluginGroup and related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugin_exceptions_table_model_unittest.cc
diff --git a/chrome/browser/plugin_exceptions_table_model_unittest.cc b/chrome/browser/plugin_exceptions_table_model_unittest.cc
index 61ffdad65be49f9071e21639c6a72d881b3b04d8..9540893b1e4248853922eac82b2d2b3eefd61e1e 100644
--- a/chrome/browser/plugin_exceptions_table_model_unittest.cc
+++ b/chrome/browser/plugin_exceptions_table_model_unittest.cc
@@ -82,20 +82,22 @@ class PluginExceptionsTableModelTest : public testing::Test {
table_model_.reset(new MockPluginExceptionsTableModel(map, NULL));
- NPAPI::PluginList::PluginMap plugins;
+ std::vector<PluginGroup> plugins;
WebPluginInfo foo_plugin;
foo_plugin.path = FilePath(FILE_PATH_LITERAL("a-foo"));
foo_plugin.name = ASCIIToUTF16("FooPlugin");
foo_plugin.enabled = true;
- PluginGroup* foo_group = PluginGroup::FromWebPluginInfo(foo_plugin);
- plugins[foo_group->identifier()] = linked_ptr<PluginGroup>(foo_group);
+ scoped_ptr<PluginGroup> foo_group(
+ PluginGroup::FromWebPluginInfo(foo_plugin));
+ plugins.push_back(*foo_group);
WebPluginInfo bar_plugin;
bar_plugin.path = FilePath(FILE_PATH_LITERAL("b-bar"));
bar_plugin.name = ASCIIToUTF16("BarPlugin");
bar_plugin.enabled = true;
- PluginGroup* bar_group = PluginGroup::FromWebPluginInfo(bar_plugin);
- plugins[bar_group->identifier()] = linked_ptr<PluginGroup>(bar_group);
+ scoped_ptr<PluginGroup> bar_group(
+ PluginGroup::FromWebPluginInfo(bar_plugin));
+ plugins.push_back(*bar_group);
table_model_->set_plugins(plugins);
table_model_->ReloadSettings();

Powered by Google App Engine
This is Rietveld 408576698