Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/browser/plugin_exceptions_table_model.cc

Issue 5516004: Clean up PluginGroup and related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugin_exceptions_table_model.cc
diff --git a/chrome/browser/plugin_exceptions_table_model.cc b/chrome/browser/plugin_exceptions_table_model.cc
index 21ed5470b1b331cf0659a0de044911b1a6a9bb57..c690908ee1aa1ee97e4ca997408da23c925385cd 100644
--- a/chrome/browser/plugin_exceptions_table_model.cc
+++ b/chrome/browser/plugin_exceptions_table_model.cc
@@ -130,17 +130,16 @@ void PluginExceptionsTableModel::ClearSettings() {
}
void PluginExceptionsTableModel::GetPlugins(
- NPAPI::PluginList::PluginMap* plugins) {
- NPAPI::PluginList::Singleton()->GetPluginGroups(false, plugins);
+ std::vector<PluginGroup>* plugin_groups) {
+ NPAPI::PluginList::Singleton()->GetPluginGroups(false, plugin_groups);
}
void PluginExceptionsTableModel::LoadSettings() {
int group_id = 0;
- NPAPI::PluginList::PluginMap plugins;
+ std::vector<PluginGroup> plugins;
GetPlugins(&plugins);
- for (NPAPI::PluginList::PluginMap::iterator it = plugins.begin();
- it != plugins.end(); ++it) {
- std::string plugin = it->first;
+ for (size_t i = 0; i < plugins.size(); ++i) {
+ std::string plugin = plugins[i].identifier();
HostContentSettingsMap::SettingsForOneType settings;
map_->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_PLUGINS,
plugin,
@@ -151,7 +150,7 @@ void PluginExceptionsTableModel::LoadSettings() {
plugin,
&otr_settings);
}
- std::wstring title = UTF16ToWide(it->second->GetGroupName());
+ std::wstring title = UTF16ToWide(plugins[i].GetGroupName());
for (HostContentSettingsMap::SettingsForOneType::iterator setting_it =
settings.begin(); setting_it != settings.end(); ++setting_it) {
SettingsEntry entry = {

Powered by Google App Engine
This is Rietveld 408576698