Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 5515009: Remove unnecessary double-shell. (Closed)

Created:
10 years ago by DaleCurtis
Modified:
9 years, 7 months ago
Reviewers:
ericli
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Remove unnecessary double-shell. Default shell for ChromeOS test image is bash. The line in question causes an extra instance of bash to be spawned. Removing the line fixes the shell-init errors. Change-Id: Icea100dc3c4f5dbf12f2185213a64afe528cacbf BUG=chromium-os:9425 TEST=Ran in production. Errors disappeared. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2e6c8a2 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3061946

Patch Set 1 #

Patch Set 2 : Leave line in place w/ comment. #

Patch Set 3 : Whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M client/common_lib/utils.py View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
10 years ago (2010-12-09 01:28:22 UTC) #1
ericli
10 years ago (2010-12-09 01:34:56 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698