client/common_lib/utils.py - Issue 5515009: Remove unnecessary double-shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/common_lib/utils.py

Issue 5515009: Remove unnecessary double-shell. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/autotest.git@master

Patch Set: Whitespace. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/common_lib/utils.py

diff --git a/client/common_lib/utils.py b/client/common_lib/utils.py

index 47f3cb4c2e11d32a7331f6d12fbc448a6ee09b7f..101599b6e324e7ab5d31e7b4725c45b8f655535c 100644

--- a/client/common_lib/utils.py

+++ b/client/common_lib/utils.py

@@ -75,7 +75,12 @@ class BgJob(object):

self.sp = subprocess.Popen(command, stdout=subprocess.PIPE,

stderr=subprocess.PIPE,

preexec_fn=self._reset_sigpipe, shell=True,

- executable="/bin/bash",

+ # Default shell in ChromeOS test image is

+ # already bash. We're seeing shell-init

+ # errors if this value is set.

+ #executable="/bin/bash",

stdin=stdin)

« no previous file with comments | « no previous file | no next file » | no next file with comments »