Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 551135: Cleanup the unittest helpers in load_log_unittest.h.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Sync and merge conflicts Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket_stream/socket_stream_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
===================================================================
--- net/url_request/url_request_unittest.cc (revision 37380)
+++ net/url_request/url_request_unittest.cc (working copy)
@@ -218,22 +218,14 @@
// The first part of the log will be for URL_REQUEST_START.
// After that, there should be an HTTP_TRANSACTION_READ_BODY
- EXPECT_TRUE(
- net::LogContains(*r.load_log(), 0,
- net::LoadLog::TYPE_URL_REQUEST_START,
- net::LoadLog::PHASE_BEGIN));
- EXPECT_TRUE(
- net::LogContains(*r.load_log(), -3,
- net::LoadLog::TYPE_URL_REQUEST_START,
- net::LoadLog::PHASE_END));
- EXPECT_TRUE(
- net::LogContains(*r.load_log(), -2,
- net::LoadLog::TYPE_HTTP_TRANSACTION_READ_BODY,
- net::LoadLog::PHASE_BEGIN));
- EXPECT_TRUE(
- net::LogContains(*r.load_log(), -1,
- net::LoadLog::TYPE_HTTP_TRANSACTION_READ_BODY,
- net::LoadLog::PHASE_END));
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *r.load_log(), 0, net::LoadLog::TYPE_URL_REQUEST_START));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *r.load_log(), -3, net::LoadLog::TYPE_URL_REQUEST_START));
+ EXPECT_TRUE(net::LogContainsBeginEvent(
+ *r.load_log(), -2, net::LoadLog::TYPE_HTTP_TRANSACTION_READ_BODY));
+ EXPECT_TRUE(net::LogContainsEndEvent(
+ *r.load_log(), -1, net::LoadLog::TYPE_HTTP_TRANSACTION_READ_BODY));
}
}
« no previous file with comments | « net/socket_stream/socket_stream_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698