Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket_stream/socket_stream_unittest.cc

Issue 551135: Cleanup the unittest helpers in load_log_unittest.h.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Sync and merge conflicts Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_unittest.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream_unittest.cc
===================================================================
--- net/socket_stream/socket_stream_unittest.cc (revision 37380)
+++ net/socket_stream/socket_stream_unittest.cc (working copy)
@@ -210,13 +210,10 @@
// The first and last entries of the LoadLog should be for
// SOCKET_STREAM_CONNECT.
- ExpectLogContains(socket_stream->load_log(), 0,
- LoadLog::TYPE_SOCKET_STREAM_CONNECT,
- LoadLog::PHASE_BEGIN);
- ExpectLogContains(socket_stream->load_log(),
- socket_stream->load_log()->entries().size() - 1,
- LoadLog::TYPE_SOCKET_STREAM_CONNECT,
- LoadLog::PHASE_END);
+ EXPECT_TRUE(LogContainsBeginEvent(
+ *socket_stream->load_log(), 0, LoadLog::TYPE_SOCKET_STREAM_CONNECT));
+ EXPECT_TRUE(LogContainsEndEvent(
+ *socket_stream->load_log(), -1, LoadLog::TYPE_SOCKET_STREAM_CONNECT));
}
} // namespace net
« no previous file with comments | « net/socket/tcp_client_socket_unittest.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698