Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/debug.cc

Issue 551093: Implementing inline caches for GenericBinaryOpStub. ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/ia32/assembler-ia32.h » ('j') | src/ia32/codegen-ia32.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
===================================================================
--- src/debug.cc (revision 3626)
+++ src/debug.cc (working copy)
@@ -125,7 +125,9 @@
if (RelocInfo::IsCodeTarget(rmode())) {
Address target = original_rinfo()->target_address();
Code* code = Code::GetCodeFromTargetAddress(target);
- if (code->is_inline_cache_stub() || RelocInfo::IsConstructCall(rmode())) {
+ if ((code->is_inline_cache_stub()
+ && code->kind() != Code::BINARY_OP_IC) ||
Mads Ager (chromium) 2010/01/22 12:14:26 I would put the '&&' on the previous line. if ((c
vladislav.kaznacheev 2010/01/22 14:09:42 Done.
+ RelocInfo::IsConstructCall(rmode())) {
break_point_++;
return;
}
@@ -1367,6 +1369,7 @@
Handle<Code>(Builtins::builtin(Builtins::KeyedStoreIC_DebugBreak));
return result;
}
+ UNREACHABLE();
}
if (RelocInfo::IsConstructCall(mode)) {
Handle<Code> result =
« no previous file with comments | « src/code-stubs.cc ('k') | src/ia32/assembler-ia32.h » ('j') | src/ia32/codegen-ia32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698