Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 55003: Make VirtualFrame::CallStub on IA32 responsible for moving arguments... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Make VirtualFrame::CallStub on IA32 responsible for moving arguments into the appropriate registers for the stub call. Since stubs that take arguments in registers do not (currently) take any arguments on the stack, the unused generality has been removed (it's easy to put back in later). Committed: http://code.google.com/p/v8/source/detail?r=1629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -83 lines) Patch
M src/codegen-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/codegen-ia32.cc View 6 chunks +17 lines, -43 lines 0 comments Download
M src/virtual-frame.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/virtual-frame-arm.h View 1 chunk +17 lines, -11 lines 0 comments Download
M src/virtual-frame-arm.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/virtual-frame-ia32.h View 1 chunk +17 lines, -8 lines 0 comments Download
M src/virtual-frame-ia32.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This is the last part of the cleanup of the way we emit calls in ...
11 years, 9 months ago (2009-03-27 07:05:43 UTC) #1
William Hesse
11 years, 9 months ago (2009-03-27 10:26:43 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698