Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 549091: Reland r36541 (which went in without any commit log by some magic). Was rever... (Closed)

Created:
10 years, 11 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)
Visibility:
Public.

Description

Reland r36541 (which went in without any commit log by some magic). Was reverted in r36550. Now I'm relanding with the full description. Port back CLD to Linux and Mac by replacing Windows API calls with ICU's equivalent APIs for normalization. I also fixed bug 23553 (Traditional Chinese is not detected) by calling LanguageCode instead of LanguageCode_ISO_639_1. The latter covers only ISO 639-1, but there are languages detected by CLD not covered by ISO 639-1. In that case, ISO 639-2 is used. In case even ISO 639-2 does not cover (e.g. Traditional Chinese), another fallback is taken by LanguageCode. The html file for CLD testing (french_sentence.html) is explicitly labelled with charset=ISO-8859-1. Original Review: http://codereview.chromium.org/523108 BUG=25206, 23553 TEST=1. CLD is built on Linux/Mac 2. The following test pass: - unit_tests: Extension*.DetectTabLang* and CompactLangDet*.* - browser_tests: ExtensionBrowserTest.Toolstrip 3. Install the 'cld extension' in chrome/common/extensions/docs/examples/api/i18n/cld and go to http://news.google.com.tw and 'zh-TW' shows up in the language badge at the upper right (upper-left in he/ar Chrome) corner. TBR=jcampan Review URL: http://codereview.chromium.org/545123 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/551070 TBR=jshin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -243 lines) Patch
M build/all.gyp View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_api_client_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +9 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/french_sentence.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_scopedptr.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/win/cld_unicodetext.cc View 2 chunks +30 lines, -78 lines 0 comments Download
M third_party/cld/base/string_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/cld/cld.gyp View 1 chunk +126 lines, -112 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jungshik at Google
10 years, 11 months ago (2010-01-19 21:32:20 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698