Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2742)

Unified Diff: chrome/renderer/render_view.h

Issue 549091: Reland r36541 (which went in without any commit log by some magic). Was rever... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/extension_api_client_unittest.cc ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.h
===================================================================
--- chrome/renderer/render_view.h (revision 36551)
+++ chrome/renderer/render_view.h (working copy)
@@ -436,9 +436,15 @@
PageTranslator* page_translator() const { return page_translator_.get(); }
- // Returns the ISO 639_1 language code of the current page
- // (ex: en, fr, zh...). Returns 'unknown' if the language could not be
- // determined.
+ // Returns the ISO 639 language code of the current page (e.g. en, fr, zh).
+ // If ISO 639-1 code is not available for the language, ISO 639-2 3-letter code
+ // will be returned (e.g. kha for Khasi and und for undtermined). For traditional
+ // Chinse, 'zh-TW' will be returned while for simplified Chinse, 'zh' will be
+ // returned.
+ // TODO(jungshik): Make it return 'he' (the correct ISO 639 code for Hebrew)
+ // instead of the obsolete 'iw'. Perhaps, it's also better to return 'zh-Hans'
+ // (or 'zh-CN') for Simplified Chinese instead of 'zh' to be aligned with
+ // 'zh-TW' for Traditional Chinse.
std::string DetectLanguage();
protected:
« no previous file with comments | « chrome/renderer/extensions/extension_api_client_unittest.cc ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698