Issue 5486001: Remove unused test file: data/ssl/page_with_blank_target.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5486001: Remove unused test file: data/ssl/page_with_blank_target.html (Closed)

Created:
10 years ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove unused test file: data/ssl/page_with_blank_target.html It looks like this used to be used by SSLUITest.TestHTTPSErrorWithNoNavEntry, but is not anymore. BUG=None TEST=grep'ed for it, trybots pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67884

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -24 lines)			Patch
	D	chrome/test/data/ssl/page_with_blank_target.html	View		1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cbentzel

I found this file by grepping for ":9666/", and it looks it was used at ...

10 years ago (2010-12-01 18:42:19 UTC) #1

Jay Civelli

10 years ago (2010-12-01 19:08:16 UTC) #2

LGTM!

On Wed, Dec 1, 2010 at 10:42 AM,  <cbentzel@chromium.org> wrote:
> Reviewers: Jay Civelli,
>
> Message:
> I found this file by grepping for ":9666/", and it looks it was used at one
> point (http://codereview.chromium.org/196115) but is not anymore.
>
> Description:
> Remove unused test file: data/ssl/page_with_blank_target.html
>
> It looks like this used to be used by
> SSLUITest.TestHTTPSErrorWithNoNavEntry,
> but is not anymore.
>
> BUG=None
> TEST=grep'ed for it, trybots pass
>
> Please review this at http://codereview.chromium.org/5486001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  D chrome/test/data/ssl/page_with_blank_target.html
>
>
> Index: chrome/test/data/ssl/page_with_blank_target.html
> diff --git a/chrome/test/data/ssl/page_with_blank_target.html
> b/chrome/test/data/ssl/page_with_blank_target.html
> deleted file mode 100644
> index
>
46df5a23506634b768c52aa7720105f30a432ccd..0000000000000000000000000000000000000000
> --- a/chrome/test/data/ssl/page_with_blank_target.html
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -<html>
> -
> - <head><title>This is a simple test page</title>
> - <script>
> -  function simulateClick(target) {
> -    var evt = document.createEvent("MouseEvents");
> -    evt.initMouseEvent("click", true, true, window,
> -                       0, 0, 0, 0, 0, false, false,
> -                       false, false, 0, null);
> -
> -    return target.dispatchEvent(evt);
> -  }
> -
> -  function navigateInNewTab() {
> -    return simulateClick(document.getElementById("bad_link"));
> -  }
> -
> - </script>
> - </head>
> -
> -<a href="https://127.0.0.1:9666/files/ssl/google.html" id="bad_link"
> target="_blank">This is a bad link</a>
> -
> -</html>
> -
>
>
>

Expand Messages | Collapse Messages