Issue 196115: This CL adds a test to insure we are not regressing on http://crbug.com/19941...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196115: This CL adds a test to insure we are not regressing on http://crbug.com/19941... (Closed)

Created:
11 years, 3 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This CL adds a test to insure we are not regressing on http://crbug.com/19941 We would crash when an SSL error would happen on a page with no navigation entry. TEST=Run the test. BUG=http://crbug.com/19941 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26224

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -11 lines)			Patch
M	chrome/browser/ssl/ssl_browser_tests.cc	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/test/data/ssl/page_with_blank_target.html	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	chrome/test/ui_test_utils.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/test/ui_test_utils.cc	View		3 chunks	+19 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 3 months ago (2009-09-14 22:52:29 UTC) #2

LGTM with the following change.

http://codereview.chromium.org/196115/diff/1006/1011
File chrome/common/notification_type.h (right):

http://codereview.chromium.org/196115/diff/1006/1011#newcode234
Line 234: // Sent when a tad is added to a TabContentsDelegate. The source is
the
tad -> tab.

Expand Messages | Collapse Messages