Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 548133: Revert 36399 - linux: enable pepper_test_plugin ... (Closed)

Created:
10 years, 11 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin (slow to review), pam+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Revert 36399 - linux: enable pepper_test_plugin This is breaking official x64 builds, notified team of break earlier in the week, but haven't seen a fix. I'm reverting now. Please fix before re-enabling. Original message: This includes a way to build it with full support on x64 (and arm ?), by specifying linux_fpic=1 in GYP_DEFINES and rerunning gyp. Review URL: http://codereview.chromium.org/551041 TBR=piman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M build/all.gyp View 3 chunks +4 lines, -1 line 0 comments Download
M build/common.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/pgl/pgl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp View 3 chunks +5 lines, -13 lines 0 comments Download
M webkit/tools/pepper_test_plugin/plugin_object.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
10 years, 11 months ago (2010-01-23 22:08:42 UTC) #1
piman
10 years, 11 months ago (2010-01-23 23:18:20 UTC) #2
Sigh. It works on the public builder. I asked for more information in the thread
(do we build with different flags or compiler on the official builders ?) but
didn't get an answer.
I don't know how I can fix an ICE without having any sort of information.

Powered by Google App Engine
This is Rietveld 408576698