Issue 551041: linux: enable pepper_test_plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551041: linux: enable pepper_test_plugin (Closed)

Created:
10 years, 11 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
apatrick, neb, apatrick_chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: enable pepper_test_plugin This includes a way to build it with full support on x64 (and arm ?), by specifying linux_fpic=1 in GYP_DEFINES and re-running gyp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36399

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -11 lines)			Patch
M	build/all.gyp	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	build/common.gypi	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	gpu/pgl/pgl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp	View	1	3 chunks	+13 lines, -5 lines	0 comments	Download
M	webkit/tools/pepper_test_plugin/plugin_object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apatrick

http://codereview.chromium.org/551041/diff/1/4 File gpu/pgl/pgl.cc (right): http://codereview.chromium.org/551041/diff/1/4#newcode157 gpu/pgl/pgl.cc:157: delete static_cast<PGLContextImpl*>(pgl_context); good catch. http://codereview.chromium.org/551041/diff/1/5 File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right): http://codereview.chromium.org/551041/diff/1/5#newcode63 ...

10 years, 11 months ago (2010-01-15 06:42:32 UTC) #2

piman

http://codereview.chromium.org/551041/diff/1/5 File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right): http://codereview.chromium.org/551041/diff/1/5#newcode63 webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:63: ['OS!=mac', { On 2010/01/15 06:42:32, apatrick wrote: > 'OS!="mac"' ...

10 years, 11 months ago (2010-01-15 06:43:48 UTC) #3

LGTM

Expand Messages | Collapse Messages