Make debugger unloading deferred operation

Make debugger unloading deferred operation

This CL should make debugger handler setting an asynchronous operation for real.

Committed: http://code.google.com/p/v8/source/detail?r=3624

[Peter Rybin, 2010-01-14 21:01:59]

Hi Sorren

This CL has one TODO, which may be resolved before committing. I need you advice
here.

Peter

[Søren Thygesen Gjesse, 2010-01-15 08:54:51]

LGTM

http://codereview.chromium.org/548045/diff/8/2002
File src/debug.h (right):

http://codereview.chromium.org/548045/diff/8/2002#newcode657
src/debug.h:657: // TODO(peter.rybin): should we check that we pending unload is
still actual?
If you want a TODO in the source please create a bug for it and use the form
TODO(bug).

http://codereview.chromium.org/548045/diff/8/2002#newcode659
src/debug.h:659: // Or else Debug::ClearMirrorCache() will fail in first line.
You could add an ASSERT that the debugger is not entered.

[Peter Rybin, 2010-01-15 21:49:09]

http://codereview.chromium.org/548045/diff/8/2002
File src/debug.h (right):

http://codereview.chromium.org/548045/diff/8/2002#newcode657
src/debug.h:657: // TODO(peter.rybin): should we check that we pending unload is
still actual?
On 2010/01/15 08:54:51, Søren Gjesse wrote:
> If you want a TODO in the source please create a bug for it and use the form
> TODO(bug).

Well, maybe I don't understand it well enough yet to create a reasonable issue.

http://codereview.chromium.org/548045/diff/8/2002#newcode659
src/debug.h:659: // Or else Debug::ClearMirrorCache() will fail in first line.
On 2010/01/15 08:54:51, Søren Gjesse wrote:
> You could add an ASSERT that the debugger is not entered.

It looks like we are going to have this assert anyway (in that method). So maybe
I'm too afraid to add more ASSERTS, that are not 100% correct.