Issue 548007: arm: fix thumb/debug build...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 548007: arm: fix thumb/debug build... (Closed)

Created:
10 years, 11 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev, Erik Corry

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

arm: fix thumb/debug build r7 is a "reserved" register in Thumb mode, for the frame pointer (enabled in debug). So only define scno as "r7" in ARM, and in Thumb just manually load it into r7 after switching to ARM mode. Landed through http://codereview.chromium.org/549033.

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	src/arm/cpu-arm.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

Not sure who owns that file, so please reassign if it's not you.

10 years, 11 months ago (2010-01-12 08:58:45 UTC) #1

piman

On 2010/01/12 11:16:40, Søren Gjesse wrote: > LGTM Do you mind checking it in ? ...

10 years, 11 months ago (2010-01-13 02:18:19 UTC) #3

Søren Thygesen Gjesse

10 years, 11 months ago (2010-01-13 07:47:37 UTC) #4

On 2010/01/13 02:18:19, piman wrote:
> On 2010/01/12 11:16:40, Søren Gjesse wrote:
> > LGTM
> 
> Do you mind checking it in ? I don't have commit access to v8. Thanks !

Landed through  http://codereview.chromium.org/549033.

Expand Messages | Collapse Messages