Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 548002: Add missing instructions to the IA-32 disasembler... (Closed)

Created:
10 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add missing instructions to the IA-32 disasembler Added newly added instructions to test-disasem-ia32.cc and implemented the missi ng ones in the disasembler. Added some asserts to 8-bit instructions which only work with eax, ebx, ecx and edx (al, bl, cl and dl). Removed the loope instruction. Committed: http://code.google.com/p/v8/source/detail?r=3577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -81 lines) Patch
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 4 chunks +3 lines, -13 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +22 lines, -19 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 13 chunks +54 lines, -38 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 11 months ago (2010-01-11 14:26:10 UTC) #1
Mads Ager (chromium)
10 years, 11 months ago (2010-01-11 15:15:38 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698