install-build-deps.sh does not check version of gold linker

Currently it only installs the gold linker if it is not installed at all.  Version 2.20 is needed to complete a Release build and if the contributor has version 2.19, the gold linker will not be updated.

The checkin gets the version number of ld.  It checks if the version is gold and if it has the correct version number.

[brianlum, 2010-01-12 08:03:26]

Now checks if ld is gold and what the version number is.

[brianlum, 2010-01-12 08:06:08]

Adding agl and ajwong as reviewers

[dank, 2010-01-12 08:42:02]

drive-by review: sometimes, worse is better.
How about the ultra-cheapo approach?

http://codereview.chromium.org/547021/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/547021/diff/1/2#newcode242
build/install-build-deps.sh:242: 
That's a lovely bit of scripting, but it'd be a lot simpler
to do something like

case `ld --version` in
*gold*2.2*) ;;

which would hold us for several years...

[brianlum, 2010-01-12 09:26:10]

I'm fine with that as well.  I know ajwong would be OK with.

On Tue, Jan 12, 2010 at 12:42 AM,  <dank@chromium.org> wrote:
> drive-by review: sometimes, worse is better.
> How about the ultra-cheapo approach?
>
>
> http://codereview.chromium.org/547021/diff/1/2
> File build/install-build-deps.sh (right):
>
> http://codereview.chromium.org/547021/diff/1/2#newcode242
> build/install-build-deps.sh:242:
> That's a lovely bit of scripting, but it'd be a lot simpler
> to do something like
>
> case `ld --version` in
> *gold*2.2*) ;;
>
> which would hold us for several years...
>
> http://codereview.chromium.org/547021
>

[Evan Martin, 2010-01-12 16:49:49]

http://codereview.chromium.org/547021/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/547021/diff/1/2#newcode242
build/install-build-deps.sh:242: 
On 2010/01/12 08:42:02, dank wrote:
> That's a lovely bit of scripting, but it'd be a lot simpler
> to do something like
> 
> case `ld --version` in
> *gold*2.2*) ;;
> 
> which would hold us for several years...

I agree with this comment.

[brianlum, 2010-01-12 19:00:26]

I put *gold*2.2*

Just to let you know: gold linker came out in March 2008 as 2.19.  I don't know
if we'll be "held for several years", probably just a few. 

On 2010/01/12 16:49:49, Evan Martin wrote:
> http://codereview.chromium.org/547021/diff/1/2
> File build/install-build-deps.sh (right):
> 
> http://codereview.chromium.org/547021/diff/1/2#newcode242
> build/install-build-deps.sh:242: 
> On 2010/01/12 08:42:02, dank wrote:
> > That's a lovely bit of scripting, but it'd be a lot simpler
> > to do something like
> > 
> > case `ld --version` in
> > *gold*2.2*) ;;
> > 
> > which would hold us for several years...
> 
> I agree with this comment.

[awong, 2010-01-12 19:03:58]

LGTM

Thanks for fixing things!

As for binutils versioning, it shouldn't move way way too fast.  And, with luck,
maybe by the time it gets to binutils 2.3x, gold will be default. :) :)

[awong, 2010-01-12 21:45:32]

committed as r36042

On 2010/01/12 19:03:58, awong wrote:
> LGTM
> 
> Thanks for fixing things!
> 
> As for binutils versioning, it shouldn't move way way too fast.  And, with
luck,
> maybe by the time it gets to binutils 2.3x, gold will be default. :) :)