Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 5469001: Merge 67824 - Stopgap fix for crash in issue 53867 comment 15... (Closed)

Created:
10 years ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, Alpha Left Google, ddorwin+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, brettw-cc_chromium.org, darin-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Merge 67824 - Stopgap fix for crash in issue 53867 comment 15 gwtquake lets the renderer create > 300 threads (one per audio element?), and eventually thread creation fails. This CL makes the media code more robust against thread creation failure (currently, it just crashes the renderer). The Real Fix probably is to have a thread pool for media stuff instead of one thread per media object. And maybe threads just leak under some circumstances. I will file a follow-up bug for that case, hopefully with a reduced test case. BUG=53867, 61293 TEST=Completing the first level in gwtquake shouldn't crash the renderer. Review URL: http://codereview.chromium.org/5362003 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -80 lines) Patch
M chrome/renderer/render_view.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M media/base/pipeline_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline_impl.cc View 9 chunks +68 lines, -54 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 1 chunk +9 lines, -5 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 3 chunks +18 lines, -10 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
10 years ago (2010-12-01 15:48:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698