Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 546116: Adding geolocation data provider infrastructure to Chrome.... (Closed)

Created:
10 years, 11 months ago by joth
Modified:
9 years, 7 months ago
Reviewers:
jorlow
CC:
chromium-reviews
Visibility:
Public.

Description

Adding geolocation data provider infrastructure to Chrome. These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/ NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on. BUG=11246 TEST=None (just adding placeholder files; tests will follow in next change) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37009

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1934 lines, -0 lines) Patch
A chrome/browser/geolocation/device_data_provider.h View 1 chunk +391 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/empty_device_data_provider.h View 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/empty_device_data_provider.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_common.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_common.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_linux.h View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_linux.cc View 1 chunk +279 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_osx.h View 1 chunk +71 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_osx.cc View 1 chunk +168 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_win.h View 1 chunk +87 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_win.cc View 1 chunk +534 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_windows_common.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/geolocation/wifi_data_provider_windows_common.cc View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
joth
As discussed, this is the vanilla check in of gears files. No mods, loads of ...
10 years, 11 months ago (2010-01-22 18:43:44 UTC) #1
joth
- for reference, I've started to prepare the edits to these files in http://codereview.chromium.org/543174/show
10 years, 11 months ago (2010-01-22 18:49:52 UTC) #2
jorlow
<rubber stamped> But please move these to the browser directory. The providers should not be ...
10 years, 11 months ago (2010-01-22 18:55:24 UTC) #3
joth
10 years, 11 months ago (2010-01-25 16:43:17 UTC) #4
yep, it's browser only. relocated the files to browser/geolocation and will
commit shortly.


2010/1/22 <jorlow@chromium.org>

> <rubber stamped>
>
> But please move these to the browser directory.  The providers should not
> be
> used outside of it, right?
>
>
> http://codereview.chromium.org/546116
>

Powered by Google App Engine
This is Rietveld 408576698