Issue 546104: Fix FullTabModeIE_ChromeFrameDeleteCookieTest. The problem was that a domain...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 546104: Fix FullTabModeIE_ChromeFrameDeleteCookieTest. The problem was that a domain... (Closed)

Created:
10 years, 11 months ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com, amit, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix FullTabModeIE_ChromeFrameDeleteCookieTest. The problem was that a domain cookie was being set twice although only set once by the server. The test itself needed fixing as well as an extra check for domain cookies set by a different url than the current url. There's one other problem remaining however which was initially reported in bug 30786 and I'll get on that next (bug reopened). TEST=Run the FullTabModeIE_ChromeFrameDeleteCookieTest test. BUG=32546, 30786 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36749

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -33 lines)			Patch
M	chrome/browser/automation/automation_profile_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/url_request_automation_job.cc	View	1 2	4 chunks	+42 lines, -18 lines	0 comments	Download
M	chrome_frame/http_negotiate.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_unittests.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome_frame/test/data/fulltab_delete_cookie_test.html	View		1 chunk	+8 lines, -12 lines	0 comments	Download
M	chrome_frame/urlmon_url_request.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 546104: Fix FullTabModeIE_ChromeFrameDeleteCookieTest. The problem was that a domain... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages