Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10604)

Unified Diff: chrome_frame/test/data/fulltab_delete_cookie_test.html

Issue 546104: Fix FullTabModeIE_ChromeFrameDeleteCookieTest. The problem was that a domain... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/chrome_frame_unittests.cc ('k') | chrome_frame/urlmon_url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/data/fulltab_delete_cookie_test.html
===================================================================
--- chrome_frame/test/data/fulltab_delete_cookie_test.html (revision 36629)
+++ chrome_frame/test/data/fulltab_delete_cookie_test.html (working copy)
@@ -14,26 +14,22 @@
return;
}
- // The path of the cookie in this test is set to "/." As a result it
- // is set twice, once for the original URL and once for the
- // chrome_frame_tester_helpers.js script. We attempt to delete
- // the cookie twice and validate that the end result is null.
+ // The path of the cookie in this test is set to "/." so it should be
+ // available for all files on the domain but should be set only once.
// First validate that the document cookie contains the substring
- // CF_FullTabDeleteCookie=1; CF_FullTabDeleteCookie=1
+ // "CF_FullTabDeleteCookie=1".
// Then erase the first cookie and validate that it no longer contains
// this string.
- var cookie_found =
- /CF_FullTabDeleteCookie=1; CF_FullTabDeleteCookie=1/.test(
- document.cookie);
+ var original_cookies = document.cookie;
+ var cookie_found = /CF_FullTabDeleteCookie=1/.test(document.cookie);
if (cookie_found) {
eraseCookie("CF_FullTabDeleteCookie");
- cookie_found =
- /CF_FullTabDeleteCookie=1; CF_FullTabDeleteCookie=1/.test(
- document.cookie);
+ cookie_found = /CF_FullTabDeleteCookie=1/.test(document.cookie);
if (!cookie_found) {
onSuccess("FullTab_DeleteCookieTest", 1);
} else {
- onFailure("FullTab_DeleteCookieTest", 1, "Delete cookie failed");
+ onFailure("FullTab_DeleteCookieTest", 1,
+ "CF_FullTabDeleteCookie still exists: " + original_cookies);
}
} else {
onFailure("FullTab_DeleteCookieTest", 1, "Expected cookies not set");
« no previous file with comments | « chrome_frame/test/chrome_frame_unittests.cc ('k') | chrome_frame/urlmon_url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698