First take on zsh-completion functionality for gclient....

First take on zsh-completion functionality for gclient.

It's very basic, only subcommands.

If this would evolve, generation of _gclient should be automized (like a separate command
or some other tool.)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36521

[antonm, 2010-01-18 17:42:49]

Marc-Antoine,

I hope I gcl'ed it vs. right svn repo, sorry if I was wrong.

Files probably need some copyright headers, but I have virtually no experience
with this stuff, I didn't add any---could you point me out the place from which
to borrow?

[M-A Ruel, 2010-01-18 21:50:06]

On 2010/01/18 17:42:49, antonm wrote:
> I hope I gcl'ed it vs. right svn repo, sorry if I was wrong.

You used a http:// checkout, you'll need a svn:// checkout to be able to check
that in.


> Files probably need some copyright headers, but I have virtually no experience
> with this stuff, I didn't add any---could you point me out the place from
which
> to borrow?

Don't bother for stuff this short.

lgtm

[M-A Ruel, 2010-01-18 21:50:19]

http://codereview.chromium.org/546069/diff/4001/5002
File zsh-goodies/README (right):

http://codereview.chromium.org/546069/diff/4001/5002#newcode3
zsh-goodies/README:3: _gclient: completion, to install add a path to zsh-goodies
into your fpath variable, e.g.:
Please wrap to 80 cols

[antonm, 2010-01-19 12:06:58]

All done and committed.  Thanks a lot for review, Marc-Antoine.

yours,
anton.

On Tue, Jan 19, 2010 at 12:50 AM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/546069/diff/4001/5002
> File zsh-goodies/README (right):
>
> http://codereview.chromium.org/546069/diff/4001/5002#newcode3
> zsh-goodies/README:3: _gclient: completion, to install add a path to
> zsh-goodies into your fpath variable, e.g.:
> Please wrap to 80 cols
>
> http://codereview.chromium.org/546069
>

[antonm, 2010-01-19 12:12:28]

I've committed to svn://chrome-svn/chrome/trunk/tools/depot_tools and
that probably was wrong, yes?

yours,
anton.

On Tue, Jan 19, 2010 at 3:06 PM, Anton Muhin <antonm@chromium.org> wrote:
> All done and committed.  Thanks a lot for review, Marc-Antoine.
>
> yours,
> anton.
>
> On Tue, Jan 19, 2010 at 12:50 AM,  <maruel@chromium.org> wrote:
>>
>> http://codereview.chromium.org/546069/diff/4001/5002
>> File zsh-goodies/README (right):
>>
>> http://codereview.chromium.org/546069/diff/4001/5002#newcode3
>> zsh-goodies/README:3: _gclient: completion, to install add a path to
>> zsh-goodies into your fpath variable, e.g.:
>> Please wrap to 80 cols
>>
>> http://codereview.chromium.org/546069
>>
>