Make the Pepper test run on the mac.

Make the Pepepr test run on the mac.

BUG=none
TESTS=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36264

[sehr (please use chromium), 2010-01-14 18:02:24]

Two small issues, otherwise LGTM from me.  Probably still best to wait for
brettw's review before committing.

http://codereview.chromium.org/546041/diff/7001/8002
File webkit/tools/pepper_test_plugin/README (right):

http://codereview.chromium.org/546041/diff/7001/8002#newcode37
webkit/tools/pepper_test_plugin/README:37: ~/Library/Internert\ Plug-Ins
directory.  You could make a symbolic link like
s/Internert/Internet/

http://codereview.chromium.org/546041/diff/7001/8003
File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right):

http://codereview.chromium.org/546041/diff/7001/8003#newcode75
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:75: # There isn't a way
to add an Xcode Custom Executable via GYP.  Follow these steps to
Isn't this blob just a copy of the README instructions?  If so, please remove it
here.

http://codereview.chromium.org/546041/diff/7001/8003#newcode87
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:87: # This is what would
be great to have in GYP:
Maybe leave this part (here down) here.

[stuartmorgan, 2010-01-14 18:13:18]

http://codereview.chromium.org/546041/diff/7001/8001
File webkit/tools/pepper_test_plugin/Info.plist (right):

http://codereview.chromium.org/546041/diff/7001/8001#newcode10
webkit/tools/pepper_test_plugin/Info.plist:10: <string>420+, Copyright 2006
Apple Computer, Inc.</string>
Is this right?

http://codereview.chromium.org/546041/diff/7001/8001#newcode33
webkit/tools/pepper_test_plugin/Info.plist:33:
<key>pepper-application/x-pepper-test-plugin</key>
You probably want to add this to the whitelist in plugin_list_mac.mm in case we
go back to blacklist-by-default on the beta branch.

http://codereview.chromium.org/546041/diff/7001/8002
File webkit/tools/pepper_test_plugin/README (right):

http://codereview.chromium.org/546041/diff/7001/8002#newcode37
webkit/tools/pepper_test_plugin/README:37: ~/Library/Internert\ Plug-Ins
directory.  You could make a symbolic link like
The way we usually handle test plugins is to copy them into the special testing
directory (on the Mac, inside the built Chromium.app or TestShell.app) as part
of the test; you might want to do the same thing here.

[David Springer, 2010-01-14 19:49:00]

http://codereview.chromium.org/546041/diff/7001/8001
File webkit/tools/pepper_test_plugin/Info.plist (right):

http://codereview.chromium.org/546041/diff/7001/8001#newcode10
webkit/tools/pepper_test_plugin/Info.plist:10: <string>420+, Copyright 2006
Apple Computer, Inc.</string>
On 2010/01/14 18:13:19, stuartmorgan wrote:
> Is this right?

Done.

http://codereview.chromium.org/546041/diff/7001/8001#newcode33
webkit/tools/pepper_test_plugin/Info.plist:33:
<key>pepper-application/x-pepper-test-plugin</key>
On 2010/01/14 18:13:19, stuartmorgan wrote:
> You probably want to add this to the whitelist in plugin_list_mac.mm in case
we
> go back to blacklist-by-default on the beta branch.

Done.

http://codereview.chromium.org/546041/diff/7001/8002
File webkit/tools/pepper_test_plugin/README (right):

http://codereview.chromium.org/546041/diff/7001/8002#newcode37
webkit/tools/pepper_test_plugin/README:37: ~/Library/Internert\ Plug-Ins
directory.  You could make a symbolic link like
On 2010/01/14 18:02:24, sehr wrote:
> s/Internert/Internet/

Fixed per Stuart's comments.

http://codereview.chromium.org/546041/diff/7001/8003
File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right):

http://codereview.chromium.org/546041/diff/7001/8003#newcode75
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:75: # There isn't a way
to add an Xcode Custom Executable via GYP.  Follow these steps to
On 2010/01/14 18:02:24, sehr wrote:
> Isn't this blob just a copy of the README instructions?  If so, please remove
it
> here.

Done.

http://codereview.chromium.org/546041/diff/7001/8003#newcode87
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:87: # This is what would
be great to have in GYP:
On 2010/01/14 18:02:24, sehr wrote:
> Maybe leave this part (here down) here.

I left this in, and added a "See README" comment.
Done.

[stuartmorgan, 2010-01-14 19:55:11]

LGTM with nits

http://codereview.chromium.org/546041/diff/3005/3006
File webkit/tools/pepper_test_plugin/Info.plist (right):

http://codereview.chromium.org/546041/diff/3005/3006#newcode10
webkit/tools/pepper_test_plugin/Info.plist:10: <string>420+, Copyright 2006
Apple Computer, Inc.</string>
The change doesn't seem to have made it into the CL

http://codereview.chromium.org/546041/diff/3005/3008
File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right):

http://codereview.chromium.org/546041/diff/3005/3008#newcode51
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:51: },
The spacing is off here (tabs?)

http://codereview.chromium.org/546041/diff/3005/3008#newcode77
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:77: #  ['OS=="mac"', {
Spacing again.

[David Springer, 2010-01-14 20:07:27]

http://codereview.chromium.org/546041/diff/3005/3006
File webkit/tools/pepper_test_plugin/Info.plist (right):

http://codereview.chromium.org/546041/diff/3005/3006#newcode10
webkit/tools/pepper_test_plugin/Info.plist:10: <string>420+, Copyright 2006
Apple Computer, Inc.</string>
On 2010/01/14 19:55:11, stuartmorgan wrote:
> The change doesn't seem to have made it into the CL

Done.  Again...

http://codereview.chromium.org/546041/diff/3005/3008
File webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp (right):

http://codereview.chromium.org/546041/diff/3005/3008#newcode51
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:51: },
On 2010/01/14 19:55:11, stuartmorgan wrote:
> The spacing is off here (tabs?)

Done.

http://codereview.chromium.org/546041/diff/3005/3008#newcode77
webkit/tools/pepper_test_plugin/pepper_test_plugin.gyp:77: #  ['OS=="mac"', {
On 2010/01/14 19:55:11, stuartmorgan wrote:
> Spacing again.

Done.

[brettw, 2010-01-14 22:01:17]

Belated LGTM, sorry I was slow, and thanks for fixing this.