Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 546022: gclient: git relative url implementation (Closed)

Created:
10 years, 11 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

gclient: git relative url implementation Redo relative url implementation per maruel's comments here: http://codereview.chromium.org/500015 Instead of adding an option, implement relative urls differently for git urls. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -53 lines) Patch
M gclient.py View 2 chunks +4 lines, -9 lines 0 comments Download
M gclient_scm.py View 2 chunks +10 lines, -0 lines 0 comments Download
M gclient_utils.py View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/gclient_scm_test.py View 3 chunks +23 lines, -6 lines 0 comments Download
M tests/gclient_test.py View 4 chunks +16 lines, -13 lines 0 comments Download
M tests/gclient_utils_test.py View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mandeep Singh Baines
10 years, 11 months ago (2010-01-12 23:25:12 UTC) #1
Nasser Grainawi
lgtm On 2010/01/12 23:25:12, msb wrote: >
10 years, 11 months ago (2010-01-13 01:38:51 UTC) #2
M-A Ruel
10 years, 11 months ago (2010-01-13 01:55:21 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698