Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: tests/gclient_test.py

Issue 546022: gclient: git relative url implementation (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/gclient_scm_test.py ('k') | tests/gclient_utils_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_test.py
diff --git a/tests/gclient_test.py b/tests/gclient_test.py
index aaa007c3e41af197370d7c27344d5f55f6930b21..e21c20ae7dceef52a27e55f185d426d8a7347954 100755
--- a/tests/gclient_test.py
+++ b/tests/gclient_test.py
@@ -47,7 +47,6 @@ class GClientBaseTestCase(BaseTestCase):
self.mox.StubOutWithMock(gclient.gclient_utils, 'FileWrite')
self.mox.StubOutWithMock(gclient.gclient_utils, 'SubprocessCall')
self.mox.StubOutWithMock(gclient.gclient_utils, 'RemoveDirectory')
- self.mox.StubOutWithMock(gclient.gclient_utils, 'FullUrlFromRelative')
# Mock them to be sure nothing bad happens.
self.mox.StubOutWithMock(gclient.gclient_scm.scm.SVN, 'Capture')
self.mox.StubOutWithMock(gclient.gclient_scm.scm.SVN, 'CaptureInfo')
@@ -798,13 +797,15 @@ deps_os = {
scm_wrapper_src)
scm_wrapper_src.RunCommand('update', mox.Func(OptIsRev123), self.args, [])
- gclient.gclient_utils.FullUrlFromRelative(self.url,
- '/trunk/deps/third_party/cygwin@3248'
- ).AndReturn(cygwin_path)
+ gclient.gclient_scm.CreateSCM(self.url, self.root_dir,
+ None).AndReturn(scm_wrapper_src2)
+ scm_wrapper_src2.FullUrlForRelativeUrl('/trunk/deps/third_party/cygwin@3248'
+ ).AndReturn(cygwin_path)
- gclient.gclient_utils.FullUrlFromRelative(self.url,
- '/trunk/deps/third_party/WebKit'
- ).AndReturn(webkit_path)
+ gclient.gclient_scm.CreateSCM(self.url, self.root_dir,
+ None).AndReturn(scm_wrapper_src2)
+ scm_wrapper_src2.FullUrlForRelativeUrl('/trunk/deps/third_party/WebKit'
+ ).AndReturn(webkit_path)
gclient.gclient_scm.CreateSCM(
webkit_path, self.root_dir, 'foo/third_party/WebKit'
@@ -912,9 +913,10 @@ deps = {
gclient.gclient_scm.CreateSCM)
gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
- gclient.gclient_utils.FullUrlFromRelative(self.url,
- '/trunk/bar/WebKit',
- ).AndReturn(webkit_path)
+ gclient.gclient_scm.CreateSCM(self.url, self.root_dir, None
+ ).AndReturn(scm_wrapper_src)
+ scm_wrapper_src.FullUrlForRelativeUrl('/trunk/bar/WebKit'
+ ).AndReturn(webkit_path)
gclient.gclient_scm.CreateSCM(
webkit_path, self.root_dir, 'foo/third_party/WebKit'
@@ -975,9 +977,10 @@ deps = {
gclient.gclient_scm.CreateSCM)
gclient.gclient_scm.CreateSCM.RunCommand('update', options, self.args, [])
- gclient.gclient_utils.FullUrlFromRelative(self.url,
- '/trunk/bar_custom/WebKit'
- ).AndReturn(webkit_path)
+ gclient.gclient_scm.CreateSCM(self.url, self.root_dir,
+ None).AndReturn(scm_wrapper_src)
+ scm_wrapper_src.FullUrlForRelativeUrl('/trunk/bar_custom/WebKit'
+ ).AndReturn(webkit_path)
gclient.gclient_scm.CreateSCM(webkit_path, self.root_dir,
'foo/third_party/WebKit').AndReturn(gclient.gclient_scm.CreateSCM)
« no previous file with comments | « tests/gclient_scm_test.py ('k') | tests/gclient_utils_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698