Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 545178: Wait for the DB thread to finish posting tasks to the main thread... (Closed)

Created:
10 years, 11 months ago by dumi
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw+cc_chromium.org, darin (slow to review), jam
Visibility:
Public.

Description

Wait for the DB thread to finish posting tasks to the main thread before setting the WebKit client to NULL. TEST=none BUG=32228, 32226 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37594

Patch Set 1 #

Patch Set 2 : Should be ready for review. #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : Minor fix, trybots should turn green. #

Total comments: 2

Patch Set 5 : Addressed Darin's comments. #

Patch Set 6 : Addressed Darin's comments. #

Patch Set 7 : Now with the correct legal header... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M chrome/renderer/render_thread.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_web_database_observer.h View 1 2 3 4 5 6 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_web_database_observer.cc View 1 2 3 4 2 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaeln
http://codereview.chromium.org/545178/diff/2001/2004 File chrome/renderer/render_thread.cc (right): http://codereview.chromium.org/545178/diff/2001/2004#newcode219 chrome/renderer/render_thread.cc:219: renderer_web_database_observer_->WaitForAllDatabasesToClose(); If database threads are still running, they may ...
10 years, 11 months ago (2010-01-23 01:48:34 UTC) #1
dumi
http://codereview.chromium.org/545178/diff/2001/2004 File chrome/renderer/render_thread.cc (right): http://codereview.chromium.org/545178/diff/2001/2004#newcode219 chrome/renderer/render_thread.cc:219: renderer_web_database_observer_->WaitForAllDatabasesToClose(); On 2010/01/23 01:48:35, michaeln wrote: > If database ...
10 years, 11 months ago (2010-01-23 04:40:46 UTC) #2
michaeln
> > Also, DBMessageFilter... what if a background thread is waiting for a > result... ...
10 years, 11 months ago (2010-01-23 20:37:34 UTC) #3
dumi
On 2010/01/23 20:37:34, michaeln wrote: > > > Also, DBMessageFilter... what if a background thread ...
10 years, 11 months ago (2010-01-26 02:15:18 UTC) #4
michaeln1
On Mon, Jan 25, 2010 at 6:15 PM, <dumi@chromium.org> wrote: > On 2010/01/23 20:37:34, michaeln ...
10 years, 11 months ago (2010-01-26 02:38:29 UTC) #5
dumi
> I don't follow why we would want to disable "sudden termination"? Your > changes ...
10 years, 11 months ago (2010-01-26 02:52:42 UTC) #6
darin (slow to review)
http://codereview.chromium.org/545178/diff/8001/8002 File chrome/renderer/renderer_web_database_observer.cc (right): http://codereview.chromium.org/545178/diff/8001/8002#newcode43 chrome/renderer/renderer_web_database_observer.cc:43: MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask()); Why not just call MessageLoop::current()->Quit()?
10 years, 10 months ago (2010-01-29 22:51:45 UTC) #7
dumi
10 years, 10 months ago (2010-01-29 22:55:25 UTC) #8
http://codereview.chromium.org/545178/diff/8001/8002
File chrome/renderer/renderer_web_database_observer.cc (right):

http://codereview.chromium.org/545178/diff/8001/8002#newcode43
chrome/renderer/renderer_web_database_observer.cc:43:
MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask());
On 2010/01/29 22:51:45, darin wrote:
> Why not just call MessageLoop::current()->Quit()?

done.

Powered by Google App Engine
This is Rietveld 408576698