Issue 545159: Insert diagnostics in an attempt to track down a crash in popup menus...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545159: Insert diagnostics in an attempt to track down a crash in popup menus... (Closed)

Created:
10 years, 11 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Insert diagnostics in an attempt to track down a crash in popup menus in RenderWidgetHostViewMac::ShowPopupWithItems(). BUG=31716 TEST=should have no user-visible effect; see crash reports Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36790

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  Let's see how this shakes out.  Thanks.

Expand Messages | Collapse Messages