Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 545159: Insert diagnostics in an attempt to track down a crash in popup menus... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm
===================================================================
--- chrome/browser/renderer_host/render_widget_host_view_mac.mm (revision 36540)
+++ chrome/browser/renderer_host/render_widget_host_view_mac.mm (working copy)
@@ -419,8 +419,12 @@
[menu_runner indexOfSelectedItem],
position, view_rect);
+ // CHECK()s inserted to diagnose the crash in http://crbug.com/31716
+ // TODO(pamg): Remove when no longer needed.
+ CHECK(render_widget_host_);
if ([menu_runner menuItemWasChosen]) {
// Simulate a menu selection event.
+ CHECK(cocoa_view_);
const WebMouseEvent& mouse_event =
WebInputEventFactory::mouseEvent(event, cocoa_view_);
render_widget_host_->ForwardMouseEvent(mouse_event);
@@ -577,6 +581,13 @@
return self;
}
+// Used only to diagnose the crash in http://crbug.com/31716
+// TODO(pamg): Remove when no longer needed.
+- (void)dealloc {
+ renderWidgetHostView_->clear_cocoa_view();
+ [super dealloc];
+}
+
- (void)setCanBeKeyView:(BOOL)can {
canBeKeyView_ = can;
}
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698