Issue 545012: Merge the intranet redirect blacklist to 249. Contains the following two cha...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545012: Merge the intranet redirect blacklist to 249. Contains the following two cha... (Closed)

Created:
10 years, 11 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
laforge

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge the intranet redirect blacklist to 249. Contains the following two changes: === Blacklist particular TLD+1s for accidental search infobars, to avoid showing the user an infobar on all kinds of searches. BUG=31043 TEST=Legit intranet sites should still produce infobars. Search terms which previously generated infobars on Comcast/Verizon should not. Review URL: http://codereview.chromium.org/523043 === I forgot that GURL doesn't do fixup. BUG=31043 TEST=none Review URL: http://codereview.chromium.org/521026 === TBR=laforge BUG=31043 Test=See above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35920

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	chrome/browser/alternate_nav_url_fetcher.cc	View		2 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages