Issue 523043: Blacklist particular TLD+1s for accidental search infobars, to avoid showing ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 523043: Blacklist particular TLD+1s for accidental search infobars, to avoid showing ... (Closed)

Created:
10 years, 11 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky, Evan Martin

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Blacklist particular TLD+1s for accidental search infobars, to avoid showing the user an infobar on all kinds of searches. BUG=31043 TEST=Legit intranet sites should still produce infobars. Search terms which previously generated infobars on Comcast/Verizon should not. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35493

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	chrome/browser/alternate_nav_url_fetcher.cc	View		2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

10 years, 11 months ago (2010-01-05 00:53:21 UTC) #4

On 2010/01/05 00:50:59, Evan Martin wrote:
> yay, glad you did this

Evan, if you can either check a trunk build, or check next week's dev release
when it comes out (the fix won't be in this week's release), I'd really
appreciate it.

Expand Messages | Collapse Messages