chrome/browser/prefs/scoped_pref_update.cc - Issue 5441002: Clean up pref change notification handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/scoped_pref_update.cc

Issue 5441002: Clean up pref change notification handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix extension prefs breakage Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/scoped_pref_update.cc

diff --git a/chrome/browser/prefs/scoped_pref_update.cc b/chrome/browser/prefs/scoped_pref_update.cc

index 05a607cfd0b7ea8df9ff8e2e5ec9950a80a9cda7..024d71bf1e258afd5da30155f50eb1f3dc483542 100644

--- a/chrome/browser/prefs/scoped_pref_update.cc

+++ b/chrome/browser/prefs/scoped_pref_update.cc

@@ -12,5 +12,8 @@ ScopedPrefUpdate::ScopedPrefUpdate(PrefService* service, const char* path)

path_(path) {}

ScopedPrefUpdate::~ScopedPrefUpdate() {

- service_->pref_notifier()->FireObservers(path_.c_str());

+ // TODO(mnissler, danno): This sends a notification unconditionally, which is

+ // wrong. We should rather tell the PrefService that the user pref got

+ // updated.

+ service_->pref_notifier()->OnPreferenceChanged(path_.c_str());

}