chrome/browser/prefs/scoped_pref_update.cc - Issue 5441002: Clean up pref change notification handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/scoped_pref_update.cc

Issue 5441002: Clean up pref change notification handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix extension prefs breakage Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/prefs/scoped_pref_update.h"	5 #include "chrome/browser/prefs/scoped_pref_update.h"

6	6

7 #include "chrome/browser/prefs/pref_notifier.h"	7 #include "chrome/browser/prefs/pref_notifier.h"

8 #include "chrome/browser/prefs/pref_service.h"	8 #include "chrome/browser/prefs/pref_service.h"

9	9

10 ScopedPrefUpdate::ScopedPrefUpdate(PrefService* service, const char* path)	10 ScopedPrefUpdate::ScopedPrefUpdate(PrefService* service, const char* path)

11 : service_(service),	11 : service_(service),

12 path_(path) {}	12 path_(path) {}

13	13

14 ScopedPrefUpdate::~ScopedPrefUpdate() {	14 ScopedPrefUpdate::~ScopedPrefUpdate() {

15 service_->pref_notifier()->FireObservers(path_.c_str());	15 // TODO(mnissler, danno): This sends a notification unconditionally, which is

	16 // wrong. We should rather tell the PrefService that the user pref got

	17 // updated.

	18 service_->pref_notifier()->OnPreferenceChanged(path_.c_str());

16 }	19 }

OLD	NEW